Skip site navigation (1) Skip section navigation (2)

Re: pg_ctl configurable timeout

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_ctl configurable timeout
Date: 2007-10-29 20:24:19
Message-ID: 25778.1193689459@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Somehow, the 60 second timeout seems completely arbitrary anyway.  Maybe we 
> should remove it altogether.  We could add an option as described above, but 
> then the packager who creates the init script or whoever creates the initial 
> configuration will have to make an equally arbitrary choice.

Yeah.  One problem is that we use the same timeout for startup and
shutdown, which really are entirely different; and the other problem
is that we've not wanted pg_ctl to have too many smarts about the
server's internal behavior.

On startup, it would be reasonable to assume failure if we don't see
a postmaster pid-file appear PDQ, but then after that it might stay
in the "database is starting up" state for a long time (maybe even
indefinitely if it's a warm standby server).  Still, you could argue
that it's reasonable to keep waiting as long as the postmaster keeps
returning "database is starting up" when pinged.

On shutdown, it'd be reasonable to expect that the postmaster starts
returning "database is shutting down" almost immediately, and to report
failure if not.  However, if it was a default "smart mode" stop you
could again wait indefinitely for clients to decide to give up their
sessions.  I'm not sure if it's sane for pg_ctl to wait indefinitely
in that scenario.

I agree that just pushing the choice of timeout onto the user's
shoulders wouldn't be much of an improvement.  He can always hit ^C
if he gets tired of waiting.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-10-29 20:26:50
Subject: Re: pg_ctl configurable timeout
Previous:From: Simon RiggsDate: 2007-10-29 20:16:17
Subject: Re: pg_ctl configurable timeout

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-10-29 20:26:50
Subject: Re: pg_ctl configurable timeout
Previous:From: Simon RiggsDate: 2007-10-29 20:16:17
Subject: Re: pg_ctl configurable timeout

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group