Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Explicit shell types

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Explicit shell types
Date: 2006-02-28 22:38:43
Message-ID: 2563.1141166323@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> The only thing I considered wrong with the previous patch was it's odd
> behaviour w.r.t. creation of types with the same name as one in
> pg_catalog. However, Tom said this is not a serious issue given the
> same problem exists in many other places in PostgreSQL.

> So, I've added some regression tests and here is the patch for
> inclusion.

Applied with corrections --- most notably, you weren't setting the
dependencies correctly for a shell type, and referencing numeric
function OIDs from C code is not done.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-03-01 00:23:03
Subject: Re: [HACKERS] pg_service.conf
Previous:From: Neil ConwayDate: 2006-02-28 21:36:58
Subject: Re: 2 line patch to allow plpythonu functions to return

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group