Skip site navigation (1) Skip section navigation (2)

Re: Small fix for inv_getsize

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Denis Perchine <dyp(at)perchine(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Small fix for inv_getsize
Date: 2000-11-02 16:49:38
Message-ID: 25612.973183778@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Denis Perchine <dyp(at)perchine(dot)com> writes:
> Just realized that inv_getsize is a little bit wrong :-)). It just get the 
> first page, not last
> Here is the patch which will fix the behavior.

No it doesn't; it's a loop, and your patch will change nothing.  Your
original version tried to stop after fetching one tuple, which was
wrong because of visibility considerations.

Now that I think about it, this code could do a two-key scan backwards
and stop after finding the first (last) valid tuple, but that's more
than a one-line change.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Denis PerchineDate: 2000-11-02 17:02:23
Subject: Re: Small fix for inv_getsize
Previous:From: Tom LaneDate: 2000-11-02 07:30:19
Subject: Re: Patches for REL7_0_PATCHES

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group