From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc:
Robert Haas <robertmhaas(at)gmail(dot)com>,
Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>,
pgsql-hackers(at)postgresql(dot)org
Subject:
Re: and it's not a bunny rabbit, either
Date:
2010-12-29 17:49:19
Message-ID:
25335.1293644959@sss.pgh.pa.us (view raw or flat )
Thread:
2010-12-27 03:13:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-27 03:33:15 from David Fetter <david(at)fetter(dot)org>
2010-12-27 03:44:40 from Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
2010-12-27 03:55:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-27 04:09:41 from Christophe Pettus <xof(at)thebuild(dot)com>
2010-12-27 15:18:21 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-27 19:06:52 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 04:54:46 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 09:09:56 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-12-29 11:17:57 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 17:29:23 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-12-29 17:49:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-29 18:35:07 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 19:29:45 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-29 19:42:08 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-12-29 20:01:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-29 21:04:05 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 21:53:47 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-29 22:14:35 from David Fetter <david(at)fetter(dot)org>
2010-12-30 15:47:42 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-30 16:00:02 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-12-30 16:03:35 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-31 13:48:18 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-01-01 05:05:30 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-01 14:53:57 from Guillaume Lelarge <guillaume(at)lelarge(dot)info>
2011-01-01 15:00:46 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-01 15:31:29 from Guillaume Lelarge <guillaume(at)lelarge(dot)info>
2011-01-01 21:28:34 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-01-01 21:28:10 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-01-01 22:21:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-02 21:45:29 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-01-03 15:21:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-03 15:31:07 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-12-30 16:49:20 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-30 17:06:02 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-12-30 17:32:32 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-30 19:34:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-31 01:58:20 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-31 02:19:26 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-31 02:30:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-31 05:07:18 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-31 13:10:07 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-12-31 13:35:25 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-31 13:52:49 from Peter Eisentraut <peter_e(at)gmx(dot)net>
Lists:
pgsql-hackers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Hmm, I believe the idea of heap_open is to check that the relation is
> backed by a heap that you can read with heap_beginscan+heap_next. At the
> moment that includes normal tables, sequences and toast tables. Foreign
> tables would not fall into that category.
I don't believe that that definition is documented anyplace; if we
decide that's what we want it to mean, some code comments would be in
order.
> Yeah, you're right that most of the callers of heap_open actually want
> to a tighter check than that.
I think probably most of the physical calls of heap_open are actually
associated with system catalog accesses, and the fact that the code says
heap_open not relation_open has got more to do with copy&paste than any
real thought about what we're specifying.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: David FetterDate: 2010-12-29 17:50:25Subject : Re: pg_streamrecv for 9.1?Previous :From : Heikki LinnakangasDate : 2010-12-29 17:29:23Subject : Re: and it's not a bunny rabbit, either
