Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>, Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de>
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Date: 2001-05-03 16:15:46
Message-ID: 25282.988906546@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-cygwinpgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Please commit and wrap ahead.  IMO, the #ifdef DLLIMPORT should stay in
> sqlca.h, but the #ifdef __CYGWIN__ should probably outside of it (not
> inside).

Huh?  The macro has to get defined as *something* --- for non-CYGWIN
it must become defined as empty.  Jason's code looks OK to me.

I applied the patch as it stood ... if you think you can improve the
style then go ahead ...

			regards, tom lane

In response to

Responses

pgsql-cygwin by date

Next:From: Jason TishlerDate: 2001-05-03 16:56:21
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Previous:From: Peter EisentrautDate: 2001-05-03 14:38:30
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

pgsql-patches by date

Next:From: Jason TishlerDate: 2001-05-03 16:56:21
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Previous:From: Peter EisentrautDate: 2001-05-03 14:38:30
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group