Re: Checking max_stack_depth automatically

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Checking max_stack_depth automatically
Date: 2006-10-08 17:19:09
Message-ID: 25249.1160327949@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>>> For win32, we set the stacksize in src/backend/Makefile with
>>> "-Wl,--stack=4194304". So we know at build time what it is, if that
>>> helps you...
>>
>> Well, I can just wire that value into get_stack_depth_rlimit,
>> I suppose, but it sounds crocky.

> If we do, we probably move it to a define (which could just be in the
> Makefile) so we don't accidenally change one without the other, no?

OK, I've committed changes along these lines, but I can't really test
it. Next time you make a Windows build, would you please verify that
it still defaults to max_stack_depth = 2MB, and that it will let you set
max_stack_depth no higher than 3.5MB ?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-10-08 17:45:51 pgsql: Add include needed for new getrusage() call.
Previous Message Jim C. Nasby 2006-10-08 17:12:28 Re: Should there be a charcat?