Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.
Date: 2008-10-02 13:28:24
Message-ID: 25078.1222954104@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane wrote:
>> contrib is still pretty broken.  One part of it is needing a --srcdir
>> option in pgxs.mk, which I fixed.  But some of the modules still
>> fail --- it looks like the problem is with the ones having data/
>> subdirectories.  You seem to have taken out the copying of the data
>> files into the vpath build tree, but I think you might have to
>> put it back.

> I think the right fix would be to convert those .sql files to 
> input/*.source files and have pg_regress substitute the absolute 
> directory names in them, like it is done for the backend.

Ugh.  I don't think it's acceptable to make contrib modules have to do
that.  Even if we fix all the ones in core, what of other people relying
on the pgxs infrastructure?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Brian HurtDate: 2008-10-02 13:36:26
Subject: Re: Block-level CRC checks
Previous:From: Peter EisentrautDate: 2008-10-02 13:19:53
Subject: Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.

pgsql-committers by date

Next:From: Tom LaneDate: 2008-10-02 13:47:38
Subject: pgsql: Fix improper display of fractional seconds in interval values
Previous:From: Peter EisentrautDate: 2008-10-02 13:19:53
Subject: Re: Re: [COMMITTERS] pgsql: Allow pg_regress to be run outside the build tree.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group