Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV
Date: 2003-08-04 13:49:41
Message-ID: 25054.1060004981@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Joe Conway <mail(at)joeconway(dot)com> writes:
> Note that I also changed behavior in that when trigdata->tg_event 
> doesn't match anything known -- instead of pressing on with a value of 
> "UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made 
> no sense to me, but you may not want to change existing behavior in this 
> way (even though it seems to me that it is a "should not happen" kind of 
> error).

Seems reasonable to me.  As a matter of style, the "unrecognized" elogs
should print the offending tg_event value; otherwise the patch looks fine.

> If this patch is acceptable, I'll make similar changes to plpython.

Please do.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2003-08-04 13:53:04
Subject: Re: Release changes
Previous:From: Tom LaneDate: 2003-08-04 13:46:30
Subject: Re: DROP TYPE/DROP DOMAIN

pgsql-patches by date

Next:From: Peter EisentrautDate: 2003-08-04 14:00:58
Subject: Re: [pgsql-rus] Russian NLS update: pg_dump, libpq,
Previous:From: Tom LaneDate: 2003-08-04 13:44:01
Subject: Re: 7.4 COPY BINARY Format Change

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group