Re: Fwd: postgresql-autodoc - missinterprets "version"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pitt <martin(at)piware(dot)de>
Cc: Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Fwd: postgresql-autodoc - missinterprets "version"
Date: 2004-07-10 03:58:27
Message-ID: 2505.1089431907@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Martin Pitt <martin(at)piware(dot)de> writes:
> On 2004-07-08 7:10 -0700, Stephan Szabo wrote:
>> It doesn't appear to be necessary to quote the identifier, however version
>> and "version" refer to the same identifier in this case so I wouldn't call
>> it an error, either.

> This makes sense, thank you. I reassigned this bug to
> postgresql-autodoc. Just ignoring the quotes cannot be that
> difficult...

I am not sure why VERSION is a keyword, since AFAICS it is not used in
any production in gram.y. Also, I've been harboring thoughts of fixing
things so that quote_identifier wouldn't quote "unreserved" keywords.

But having said that, it's surely postgresql-autodoc's fault that it
cannot cope with quoted identifiers. There *will* be cases where PK
field names are quoted, such as mixed-case identifiers --- you do not
need a keyword collision to make that happen.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message davidn-postgres 2004-07-10 04:22:21 Re: Improper processing of random values in sub-queries
Previous Message Tom Lane 2004-07-10 03:02:15 Re: Improper processing of random values in sub-queries