Skip site navigation (1) Skip section navigation (2)

Re: Errno checks for rmtree()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Errno checks for rmtree()
Date: 2005-02-13 01:56:21
Message-ID: 25029.1108259781@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> + 	elog(WARNING, "can not remove \"%s\": %s", filepath, strerror(errno));

"could not remove", please; read the message style guidelines.
Also, what's wrong with using %m here?

Otherwise it looks good.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-02-13 02:29:03
Subject: Re: Errno checks for rmtree()
Previous:From: Bruce MomjianDate: 2005-02-13 01:53:37
Subject: Re: Errno checks for rmtree()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group