Skip site navigation (1) Skip section navigation (2)

Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

From: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Hartmut Goebel <h(dot)goebel(at)goebel-consult(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Date: 2010-06-11 18:46:22
Message-ID: 24BFDFF6-2DC1-4B15-8E55-533DD25804A5@hi-media.com (view raw or flat)
Thread:
Lists: pgsql-bugs
Top posting, sorry for that.

--  
dim

Le 10 juin 2010 à 03:40, Robert Haas <robertmhaas(at)gmail(dot)com> a écrit :

> On Wed, Jun 9, 2010 at 9:35 PM, Bruce Momjian <bruce(at)momjian(dot)us>  
> wrote:
>> Robert Haas wrote:
>>>> I think users would rather have the restore fail, and know right  
>>>> away
>>>> they have an issue, than to do the upgrade, and find out later  
>>>> that some
>>>> of their application queries fail and they need to run around  
>>>> fixing
>>>> them. ?(FYI, pg_upgrade would use the new pg_dump and would not  
>>>> fail.)
>>>>
>>>> In a way, the fact that the restore fails can be seen as a  
>>>> feature ---
>>>> they get the error before the go live on 8.4. ?(Yeah, I am  
>>>> serious.)

+1

>>> Eeh, I've had this happen to me on earlier releases, and it didn't
>>> feel like a feature to me.  YMMV, of course.
>>
>> Would you have preferred later application failure?
>
> YES!  It's a heck of a lot easier to fix the application than it is to
> doctor the dump output with vi.

But of course you don't ever do that. What you do once the restore  
failed on you is fix the schema and the application before to upgrade.

At least you have a chance to upgrade to a working setup.
>

In response to

Responses

pgsql-bugs by date

Next:From: Robert WalkerDate: 2010-06-11 18:49:03
Subject: BUG #5500: SPI_execute_plan_with_paramlist SPI_ERROR_TRANSACTION with savepoint
Previous:From: Kevin GrittnerDate: 2010-06-11 16:51:12
Subject: Re: BUG #5499: SQL syntax bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group