Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Cause pg_proc.probin to be declared as text, not bytea.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Cause pg_proc.probin to be declared as text, not bytea.
Date: 2009-08-04 15:37:02
Message-ID: 24868.1249400222@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Is this any different from the path in "COPY foo to '/path/to/file'"?
> I suspect the probin stuff is a solution in search of a problem.

Well, the previous probin behavior is demonstrably broken.  Make a shlib
with backslash or non-ASCII in the name, create a function referencing
it, dump and reload.  Whatever your opinions are about encodings, you
won't think pg_dump did the right thing.

I'm not sure whether the more general pathname encoding issue is worth
working on or not.  In general it's a non-problem if the paths in the
server filesystem are written in the database encoding.  If they are
not, then you have to figure out what they *are* written in, and that
seems a bit tough.  But anyway that problem is hardly restricted to
probin, and a solution that works only for probin doesn't seem terribly
interesting.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-08-04 15:39:04
Subject: Re: Proposal: More portable way to support 64bit platforms
Previous:From: Robert HaasDate: 2009-08-04 15:09:47
Subject: Re: Alpha Releases: Docs?

pgsql-committers by date

Next:From: Tom LaneDate: 2009-08-04 16:08:37
Subject: pgsql: Support hex-string input and output for type BYTEA.
Previous:From: Andrew DunstanDate: 2009-08-04 15:00:49
Subject: Re: Re: [COMMITTERS] pgsql: Cause pg_proc.probin to be declared as text, not bytea.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group