Skip site navigation (1) Skip section navigation (2)

Re: BUG #5974: UNION construct type cast gives poor error message

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Jeff Wu" <jwu(at)atlassian(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5974: UNION construct type cast gives poor error message
Date: 2011-04-13 21:32:49
Message-ID: 24771.1302730369@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Consider
>> 
>> select '1' union select '1 ';
>> 
>> How many rows does that produce?  You cannot answer without
>> imputing a data type to the columns.  "text" will give a different
>> answer than "integer" or "bpchar".
 
> Well, if we were to assign both to type unknown initially, we would
> clearly need to resolve that before execution,  But I'm not
> expecting that such execution would happen before analyzing the rest
> of the query.  If the above is on the left side of a union with
 
>     select 1;
 
> the unknown could then be resolved to integer.  I expect that all of
> this should happen before any of the unions is *executed*.  Perhaps
> I'm arguing for the same thing you were, but just have my head
> tilted at a different angle?

Yes, I think you are saying the exact same thing I am, just phrased
differently: you wish that in

	(select '1' union select '2') union select 3

the fact that the third value is clearly integer would influence
the choice of the resolved type of the first UNION.  My vision of
how to implement that is different than what you seem to have in
mind, but it would come out with the same answer.  The sticking point
is just that in purely syntactic terms this is action-at-a-distance,
and so it's hard to square with the spec.  I think that our current
reading (in which the '1' and '2' get resolved as text) is actually
closer to what the spec says.

For those following along at home, there is another issue involved
here, which is our choice to treat string-literal constants the same
as NULL constants --- they're both UNKNOWN so far as the type resolution
rules go.  It's not that surprising, perhaps, that (select '1' union
select '2') is resolved as text, but newbies tend to not think that
NULL ought to act like that.  However, so far as I can see the spec
simply disallows a not-explicitly-cast NULL constant in cases like
this, which seems if anything even less friendly than what we're doing.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2011-04-13 21:50:16
Subject: Re: BUG #5978: Running postgress in a shell script fails
Previous:From: Kevin GrittnerDate: 2011-04-13 21:10:03
Subject: Re: BUG #5974: UNION construct type cast gives poor error message

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group