Re: patch for parallel pg_dump

Joachim Wieland <joe(at)mcknight(dot)de> writes:
> On Sat, Mar 10, 2012 at 9:51 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> - const char *owner, bool withOids,
>> + const char *owner,
>> + unsigned long int relpages, bool withOids,
>>
>> The new argument to ArchiveEntry() is unused. Removing it would
>> declutter things a good bit.

> How do you mean it's unused? pg_dump_sort.c uses relpages to dump the
> largest tables first. What you don't want to see in a parallel dump is
> a worker starting to dump a large table while everybody else is
> already idle...

Used or not, I think you could find a less ugly and less invasive way to
pass that around than this. We should try to avoid adding arguments to
ArchiveEntry that apply to only one object type.

(I'm also unconvinced that sorting by relation size is a good idea
anyway. Anything that makes the dump order less predictable gets
push-back, IME.)

regards, tom lane