Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: NikhilS <nikkhils(at)gmail(dot)com>
Cc: "Dave Page" <dpage(at)postgresql(dot)org>, "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>, Boonchai <boonchai(at)xsidekick(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgadmin-support(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)
Date: 2007-12-19 17:33:13
Message-ID: 24735.1198085593@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgadmin-supportpgsql-bugs
NikhilS <nikkhils(at)gmail(dot)com> writes:
>> Looks like pg_get_indexdef is unwell :-(

> yes, it was unwell in the area where the amcanorder was being processed. The
> attached patch should fix this.

Hm, there is a definitional issue here.  Should pg_get_indexdef print
this stuff at all when colno is nonzero?  The header comment says that
it is to return the column's variable or expression only.  The existing
code suppresses the opclass in this case, which to me suggests that it
should suppress DESC/ASC as well.  Which is not what Nikhil's patch
does.

Dave, I think we put in this variant of the function for pgAdmin ---
what does pgAdmin need?

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Dave PageDate: 2007-12-19 19:49:19
Subject: Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)
Previous:From: Tom LaneDate: 2007-12-19 15:25:36
Subject: Re: ltree installation error

pgadmin-support by date

Next:From: Dave PageDate: 2007-12-19 19:49:19
Subject: Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)
Previous:From: NikhilSDate: 2007-12-19 11:06:06
Subject: Re: BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group