| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reporting WAL file containing checkpoint's REDO record in pg_controldata's result |
| Date: | 2012-03-26 14:18:27 |
| Message-ID: | 24671.1332771507@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Mar 26, 2012 at 2:50 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> s/segment/file/g?
>> We're already using "file" to mean something different *internally*,
>> don't we? And since pg_controldata shows fairly internal information,
>> I'm not sure this is the best idea.
>>
>> Maybe compromise and call it "segment file" - that is both easier to
>> understand than segment, and not actually using a term that means
>> something else...
> It's also kind of wordy. I think "file" is fine.
+1 for "file". I think the internal usage of "file" to mean "roughly
4GB worth of WAL" is going to go away soon anyway, as there won't be
much reason to worry about the concept once LSN arithmetic is 64-bit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-03-26 14:29:32 | Re: Re: [COMMITTERS] pgsql: Replace empty locale name with implied value in CREATE DATABASE |
| Previous Message | Gabriele Bartolini | 2012-03-26 14:03:56 | Re: [PATCH] Support for foreign keys with arrays |