| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Rusty Conover <rconover(at)infogears(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #5412: test case produced, possible race condition. |
| Date: | 2010-04-14 14:49:36 |
| Message-ID: | 24490.1271256576@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> According to the comments above RelationClearRelation(), if it's called
> with 'rebuild=true', the caller should hold a lock on the relation, i.e
> refcnt > 0. That's not the case in RelationFlushRelation() when it
> rebuilds a new relcache entry.
> Attached patch should fix that, by incrementing the reference count
> while the entry is rebuilt. It also adds an Assertion in
> RelationClearRelation() to check that the refcnt is indeed > 0.
> Comments?
Why would this patch fix anything? It doesn't change the lock status.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin J Bluck | 2010-04-14 15:27:22 | Re: Bug in CREATE FUNCTION with character type (CONFIRMED BUG) |
| Previous Message | Rusty Conover | 2010-04-14 14:15:35 | Re: BUG #5412: test case produced, possible race condition. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-04-14 15:05:27 | shared_buffers documentation |
| Previous Message | Jaime Casanova | 2010-04-14 14:16:36 | standbycheck was:(Re: [HACKERS] testing hot standby |