Re: new compiler warnings

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't think the assert is a good idea. If it ever did happen,
>> that would promote the problem from "corrupted data in the log" to
>> "database crash".

> ... on a --enable-cassert build.

> If we think it's even remotely possible that it could happen, maybe
> we should do the loop. That would change the current "missing log
> information" situation to "interleaved log information".

The logging protocol is hosed either way.

> But if we think it would be better for data to be missing from the
> log than interleaved, the Assert could be removed and it still
> suppresses the error (at least on my machine).

As far as getting rid of the compiler warning is concerned, I find that
the

rc = write(...);
(void) rc;

suggestion works for me (gcc 4.6.1). I'm inclined to do that (and
document why) rather than put in looping code that will not make
anything better.

regards, tom lane