Skip site navigation (1) Skip section navigation (2)

Re: revised hstore patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: revised hstore patch
Date: 2009-07-22 00:13:02
Message-ID: 2436.1248221582@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> (b) many of the old names are significant collision risks.

What collision risks?  PG does not allow loadable libraries to export
their symbols, so I don't see the problem.  I recommend just keeping
those things named as they were.

> Certainly when developing this I had _SIGNIFICANT_ encouragement, some
> of it from YOU, for increasing the limit.

Yes, but that was before the interest in in-place upgrade went up.
This patch is the first place where we have to decide whether we meant
it when we said we were going to pay more attention to that.

> I'm prepared to give slightly more consideration to option #3: make
> the new code read the old format as well as the new one.

If you think you can make that work, it would solve the problem.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Jeff DavisDate: 2009-07-22 00:19:02
Subject: Re: revised hstore patch
Previous:From: Andrew GierthDate: 2009-07-22 00:06:42
Subject: Re: revised hstore patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group