Re: Fix pg_dump dependency on postgres.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_dump dependency on postgres.h
Date: 2007-11-14 15:54:03
Message-ID: 24322.1195055643@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Zdenek Kotala wrote:
>> What do you mean "not very portable"? What could be problem there?

> I'm not sure. My point is that it seems your parse.h requires
> TYPE_IS_DECLARED, but mine doesn't. What else could be lurking in there
> that requires a specific fix?

The "portability" axis of concern here is portability across different
versions of bison. ATM I believe we work with everything from 1.875 up,
and I'd be loath to give that up.

I concur with Alvaro that this feels like a kluge rather than a
permanent solution.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-11-14 16:29:07 Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords
Previous Message Tom Lane 2007-11-14 15:39:48 Re: Spinlock backoff algorithm

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-11-14 16:29:07 Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords
Previous Message Zdenek Kotala 2007-11-14 15:29:44 Re: Fix pg_dump dependency on postgres.h