Skip site navigation (1) Skip section navigation (2)

Re: Error handling for ShmemInitStruct and ShmemInitHash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Error handling for ShmemInitStruct and ShmemInitHash
Date: 2010-04-28 14:25:11
Message-ID: 24281.1272464711@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> none of the other half are printing messages that are more useful
>> than "out of shared memory" (which isn't even necessarily
>> correct).
 
> I think the messages in the locking area are a bit more useful than
> "out of shared memory", but it would be trivial to build the
> equivalent message in the ShmemInitHash function, based on the first
> parameter.

Right, I was intending to include the "name" parameter in the messages.
This would actually represent an improvement in message quality in a lot
of the cases.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2010-04-28 14:59:58
Subject: Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct
Previous:From: Mike FowlerDate: 2010-04-28 14:21:53
Subject: XML Todo List

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group