Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY
Date: 2009-08-10 20:31:55
Message-ID: 24084.1249936315@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Robert Haas escribi:
>>> The code in the new block was not reindented; it will be fixed by pgindent
>>> eventually.
>> 
>> ...breaking every patch that someone has in progress against that code?

> I guess I neglected to add "a year from now or so".  I'm not in a hurry
> to run pgindent.

Yeah --- if there are any active patches against that code (a fact not
in evidence) then reindenting now would break them now.  Leaving it till
the next pgindent run seems fine to me.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2009-08-10 20:48:43
Subject: Re: [HACKERS] BUG #4961: pg_standby.exe crashes with no args
Previous:From: Robert HaasDate: 2009-08-10 20:31:43
Subject: Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY

pgsql-committers by date

Next:From: Robert HaasDate: 2009-08-10 21:39:30
Subject: Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY
Previous:From: Robert HaasDate: 2009-08-10 20:31:43
Subject: Re: pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group