Skip site navigation (1) Skip section navigation (2)

Re: Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)
Date: 2013-01-12 21:36:39
Message-ID: 23886.1358026599@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
>>> It does *not* combine elog_start and elog_finish into one function if
>>> varargs are available although that brings a rather measurable
>>> size/performance benefit.

>> Since you've apparently already done the measurement: how much?
>> It would be a bit tedious to support two different infrastructures for
>> elog(), but if it's a big enough win maybe we should.

> Imo its pretty definitely a big enough win. So big I have a hard time
> believing it can be true without negative effects somewhere else.

Well, actually there's a pretty serious negative effect here, which is
that when it's implemented this way it's impossible to save errno for %m
before the elog argument list is evaluated.  So I think this is a no-go.
We've always had the contract that functions in the argument list could
stomp on errno without care.

If we switch to a do-while macro expansion it'd be possible to do
something like

	do {
		int save_errno = errno;
		int elevel = whatever;

		elog_internal( save_errno, elevel, fmt, __VA__ARGS__ );
	} while (0);

but this would almost certainly result in more code bloat not less,
since call sites would now be responsible for fetching errno.

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2013-01-12 22:40:06
Subject: Re: Porting to Haiku
Previous:From: Stefan KaltenbrunnerDate: 2013-01-12 21:18:27
Subject: Re: Porting to Haiku

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group