Skip site navigation (1) Skip section navigation (2)

Re: autovacuum integration attempt #3

From: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>,"PostgreSQL Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: autovacuum integration attempt #3
Date: 2004-07-21 21:58:53
Message-ID: 23596.68.175.84.212.1090447133.squirrel@68.175.84.212 (view raw or flat)
Thread:
Lists: pgsql-patches
Sorry, perhaps my initial instructions weren't clear.

You have to move the pg_autovacuum.[ch] files then apply the patch.  The
patch alters them considerably.  Should I submit the patch in a different
way?

Thanks,

Matthew


>
> I am having problem applying this.  I don't think we can just move
> pg_autovacuum.[ch] right into the backend code.  There are issues with
> include files and there is no definition for autovacuum_vacuum_base and
> other variables, and there is no AutoVacMain().  I can try guessing on
> those but I think I need a more complete patch or more complete
> instructions to get this applied.  Also, it uses the gcc-ism
> __attribute__ that isn't portable to other compilers.
>
> ---------------------------------------------------------------------------
>
> Matthew T. O'Connor wrote:
>> Ok, here is a new patch for to integrate pg_autovacuum into the backend.
>>
>> This patch adds the following to that last patch:
>> * updated to latest CVS
>> * changed GUC vars from autovac_* to autovacuum_*
>> * changed autovac_enabled GUC variable to autovacuum
>> * changed autovacuum GUC variable default to false
>> * improved autovacuum failure when row level stats aren't enabled
>>
>> As before, this patch requires pg_autovacuum.c and .h get moved
>> from contrib to src/backend/postmaster and src/include/postmaster
>> respectively. In addition, the attached pg_autovacuum.h file must be put
>> in src/include/catelog/ for the new pg_autovacuum system
>> table.
>>
>> Please apply to CVS or tell me what I need to change to get it applied.
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania
> 19073
>
>


In response to

Responses

pgsql-patches by date

Next:From: Steve HoldowayDate: 2004-07-21 22:35:38
Subject: Re: Borland c++ compile problems...
Previous:From: Mark KirkwoodDate: 2004-07-21 20:54:30
Subject: Re: win32 readline

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group