Skip site navigation (1) Skip section navigation (2)

Re: m32r tas() implementation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pitt <martin(at)piware(dot)de>
Cc: pgsql-ports(at)postgresql(dot)org, Kazuhiro Inaoka <inaoka(dot)kazuhiro(at)renesas(dot)com>
Subject: Re: m32r tas() implementation
Date: 2007-04-14 22:17:05
Message-ID: 23547.1176589025@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-ports
Martin Pitt <martin(at)piware(dot)de> writes:
> Kazuhiro Inaoka recently sent me a tas() implementation for the m32r
> architecture [1]. It applies cleanly to 8.2.3 and seems otherwise
> harmless. Do you consider applying it upstream?

The patch seems strongly dependent on an OS as well as a chip, since
<sys/tas.h> is hardly to be expected to exist everywhere.  Therefore,
it is at least short an #ifdef or so.  More generally I wonder if it's
not going at it backwards: if <sys/tas.h> exists, could we use it
regardless of CPU type?

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Kazuhiro InaokaDate: 2007-04-16 03:40:45
Subject: Re: m32r tas() implementation
Previous:From: Martin PittDate: 2007-04-14 18:54:59
Subject: m32r tas() implementation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group