Skip site navigation (1) Skip section navigation (2)

Re: crash in plancache with subtransactions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: crash in plancache with subtransactions
Date: 2010-10-22 15:19:48
Message-ID: 23453.1287760788@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 22.10.2010 06:10, Tom Lane wrote:
>> (But on the third
>> hand, what are we gonna do for back-patching to versions without the
>> plancache?)

> One simple idea is to keep a flag along with the executor state to 
> indicate that the executor state is currently in use. Set it just before 
> calling ExecEvalExpr, and reset afterwards. If the flag is already set 
> in the beginning of exec_eval_simple_expr, we have recursed, and must 
> create a new executor state.

Yeah, the same thought occurred to me in the shower this morning.
I'm concerned about possible memory leakage during repeated recursion,
but maybe that can be dealt with.  I'll look into this issue soon,
though probably not today (Red Hat work calls :-().

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2010-10-22 15:25:07
Subject: Re: Extensions, this time with a patch
Previous:From: Heikki LinnakangasDate: 2010-10-22 14:47:08
Subject: Re: Making OFF unreserved

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group