Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Date: 2010-10-22 15:10:28
Message-ID: 23250.1287760228@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Make OFF keyword unreserved.

Two comments:

* You forgot a semicolon here:

+           | ColId_or_Sconst                       { $$ = $1 }
should be
+           | ColId_or_Sconst                       { $$ = $1; }

I think this will work as-is in some versions of bison, but not all.

* The SGML documentation keyword appendix needs an update too, no?

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2010-10-22 15:42:18
Subject: Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to
Previous:From: Heikki LinnakangasDate: 2010-10-22 14:47:08
Subject: pgsql: Make OFF keyword unreserved. It's not hard to imagine wantingto

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group