Re: pgsql: Make OFF keyword unreserved. It's not hard to imagine wanting to

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> Make OFF keyword unreserved.

Two comments:

* You forgot a semicolon here:

+ | ColId_or_Sconst { $$ = $1 }
should be
+ | ColId_or_Sconst { $$ = $1; }

I think this will work as-is in some versions of bison, but not all.

* The SGML documentation keyword appendix needs an update too, no?

regards, tom lane