| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Michael Glaesemann <grzm(at)seespotcode(dot)net>, Michael Paesold <mpaesold(at)gmx(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Interval aggregate regression failure |
| Date: | 2006-08-31 19:46:08 |
| Message-ID: | 23114.1157053568@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Well, the patch only multiplies by 30, so the interval would have to
> span +5 million years to overflow. I don't see any reason to add
> rounding until we get an actual query that needs it
Have you tried your patch against the various cases that have been
discussed in the past? In particular there were several distinct
examples of this behavior posted at the beginning of the thread, and
I'd not assume that a fix for one handles them all.
BTW, while trolling for examples I came across this:
http://archives.postgresql.org/pgsql-bugs/2005-10/msg00307.php
pointing out some issues that still haven't been addressed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Browne | 2006-08-31 19:59:05 | Re: Thought provoking piece on NetBSD |
| Previous Message | Victor B. Wagner | 2006-08-31 19:44:00 | Re: [PATCHES] Backend SSL configuration enhancement |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-08-31 20:05:43 | Re: [HACKERS] Interval aggregate regression failure |
| Previous Message | Victor B. Wagner | 2006-08-31 19:44:00 | Re: [PATCHES] Backend SSL configuration enhancement |