Skip site navigation (1) Skip section navigation (2)

Re: Patch to log usage of temporary files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to log usage of temporary files
Date: 2007-01-02 23:20:37
Message-ID: 23090.1167780037@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bill Moran <wmoran(at)collaborativefusion(dot)com> writes:
> In response to Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>> Please change things to save the stat() syscall when the feature is not
>> in use.

> Do you have a suggestion on how to do that and still have the PG_TRACE1()
> work?  That was specifically requested by Simon Riggs.

Well, we are NOT paying a stat() call on every single file close,
whether Simon wants it or not.  PG_TRACE1 doesn't even do anything
on non-Solaris platforms, for pete's sake.

Perhaps it would be reasonable to define trace_temp_files as the minimum
file size to log; then you could do something like

	if (trace_temp_files > 0)
	{
	    	if (stat(vfdP->fileName, &filestats) < 0)
			elog(LOG, ...);
		else
		{
			if (filestats.st_size / BLCKSZ >= trace_temp_files)
				ereport(LOG, ...);
			PG_TRACE1(temp__file__cleanup, filestats.st_size);
		}
	}

Note that elog(ERROR) is quite inappropriate here.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Jonah H. HarrisDate: 2007-01-03 01:08:11
Subject: Re: WITH support
Previous:From: Bill MoranDate: 2007-01-02 22:15:31
Subject: Re: Patch to log usage of temporary files

pgsql-patches by date

Next:From: Peter EisentrautDate: 2007-01-03 08:52:29
Subject: Re: xlog directory at initdb time
Previous:From: Bill MoranDate: 2007-01-02 22:15:31
Subject: Re: Patch to log usage of temporary files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group