Re: Zeroing damaged pages

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Zeroing damaged pages
Date: 2006-02-23 16:54:36
Message-ID: 23067.1140713676@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> A patch prototype to make zero_damaged_pages work as advertised is
> enclosed, though the current behaviour may well be preferred, in which
> case a doc patch is more appropriate.

I don't think this is a good idea, and even if it were, the proposed
patch is a model of obscurantism.

> However, since autovacuum the window of opportunity for support to
> assist with data recovery is smaller and somewhat random.

Hmm .... it'd probably be a good idea to force zero_damaged_pages OFF in
the autovac subprocess. That parameter is only intended for interactive
use --- as you say, autovac would be a rather nasty loose cannon if it
fired up with this parameter ON.

Are there any other things that ought to be disabled in autovac?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2006-02-23 16:59:31 Re: [PERFORM] Looking for a tool to "*" pg tables as ERDs
Previous Message Tom Lane 2006-02-23 16:49:21 Re: Join with an array

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-02-23 17:08:54 Re: vacuumlo nonstandard use of \\ in a string literal
Previous Message Michael Fuhr 2006-02-23 16:32:18 vacuumlo nonstandard use of \\ in a string literal