Skip site navigation (1) Skip section navigation (2)

Re: Efficient slicing/substring of TOAST values (for comment)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Gray <jgray(at)azuli(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Efficient slicing/substring of TOAST values (for comment)
Date: 2001-10-12 00:17:00
Message-ID: 22931.1002845820@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
John Gray <jgray(at)azuli(dot)co(dot)uk> writes:
>> Some creative refactoring would help it out a lot.  Go for it, if
>> you feel like doing that.
>> 
> I've done a little tidying, repackaging of standard code etc. as a first
> step. It hasn't made the file much shorter, but has made some of the
> routines clearer where they share basically the same code for
> inheritance and permissions checking.

Great!  I'm afraid I just committed some fixes that will probably cause
a merge conflict, but I trust it won't be too painful to resolve.

> AS regards the ALTER TABLE ALTER COLUMN syntax for attstorage, should I
> use keywords for the values or just char values 'e', 'x' etc ?

I'd suggest keywords, namely the same ones used in CREATE TYPE for
these storage options.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Thomas LockhartDate: 2001-10-12 05:53:47
Subject: Re: psql: default base and password reading
Previous:From: Ricardo Caesar LenziDate: 2001-10-11 23:44:58
Subject: PyGreSQL v3.2 doesn't support INT8 types

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group