From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Alex Hunsaker <badalex(at)gmail(dot)com>
Cc:
Andrew Dunstan <andrew(at)dunslane(dot)net>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date:
2012-01-06 21:05:09
Message-ID:
22881.1325883909@sss.pgh.pa.us (view raw or flat )
Thread:
2012-01-05 23:02:48 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-05 23:31:41 from Alex Hunsaker <badalex(at)gmail(dot)com>
2012-01-05 23:59:53 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-06 03:59:33 from Alex Hunsaker <badalex(at)gmail(dot)com>
2012-01-06 07:26:07 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-01-06 13:34:30 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-06 15:49:26 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2012-01-06 16:13:40 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-06 19:02:49 from Alex Hunsaker <badalex(at)gmail(dot)com>
2012-01-06 19:13:41 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-06 21:05:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-01-13 02:28:22 from Alex Hunsaker <badalex(at)gmail(dot)com>
2012-01-13 23:07:43 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2012-01-14 00:09:17 from Alex Hunsaker <badalex(at)gmail(dot)com>
2012-01-15 21:21:53 from Andrew Dunstan <andrew(at)dunslane(dot)net>
Lists:
pgsql-committers pgsql-hackers
Alex Hunsaker <badalex(at)gmail(dot)com> writes:
> Oh my... I dunno exactly what I was smoking last night, but its a good
> thing I didn't share :-). Uh so my test program was also completely
> wrong, Ill have to redo it all. I've narrowed it down to:
> if ((type == SVt_PVGV || SvREADONLY(sv)))
> {
> if (type != SVt_PV &&
> type != SVt_NV)
> {
> sv = newSVsv(sv);
> }
> }
Has anyone tried looking at the source code for SvPVutf8 to see exactly
what cases it fails on? The fact that there's an explicit croak() call
makes me think it might not be terribly hard to tell.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Tom LaneDate: 2012-01-06 21:14:27
Subject : Re: Progress on fast path sorting, btree index creation time
Previous :From : Simon RiggsDate : 2012-01-06 20:49:37
Subject : Re: 16-bit page checksums for 9.2
pgsql-committers by date
Next :From: Robert HaasDate: 2012-01-07 03:42:42
Subject : pgsql: Improve behavior of concurrent ALTER TABLE,and do some refactor
Previous :From : Robert HaasDate : 2012-01-06 19:33:15
Subject : pgsql: Make the number of CLOG buffers adaptive,based on shared_buffer