Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.
Date: 2012-01-06 21:05:09
Message-ID: 22881.1325883909@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Alex Hunsaker <badalex(at)gmail(dot)com> writes:
> Oh my... I dunno exactly what I was smoking last night, but its a good
> thing I didn't share :-). Uh so my test program was also completely
> wrong, Ill have to redo it all. I've narrowed it down to:
>         if ((type == SVt_PVGV || SvREADONLY(sv)))
>         {
>             if (type != SVt_PV &&
>                 type != SVt_NV)
>             {
>                 sv = newSVsv(sv);
>             }
>        }

Has anyone tried looking at the source code for SvPVutf8 to see exactly
what cases it fails on?  The fact that there's an explicit croak() call
makes me think it might not be terribly hard to tell.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2012-01-06 21:14:27
Subject: Re: Progress on fast path sorting, btree index creation time
Previous:From: Simon RiggsDate: 2012-01-06 20:49:37
Subject: Re: 16-bit page checksums for 9.2

pgsql-committers by date

Next:From: Robert HaasDate: 2012-01-07 03:42:42
Subject: pgsql: Improve behavior of concurrent ALTER TABLE,and do some refactor
Previous:From: Robert HaasDate: 2012-01-06 19:33:15
Subject: pgsql: Make the number of CLOG buffers adaptive,based on shared_buffer

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group