Skip site navigation (1) Skip section navigation (2)

Re: Efficient slicing/substring of TOAST values (reprise)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Gray <jgray(at)azuli(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Efficient slicing/substring of TOAST values (reprise)
Date: 2001-10-16 21:56:49
Message-ID: 22772.1003269409@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
John Gray <jgray(at)azuli(dot)co(dot)uk> writes:
> Things I've noticed in passing:

> 1. utils/adt/varlena.c There could be some performance gains for the
> length functions if the PG_GETARG API allowed for finding the length of
> a value without detoasting it.

This is doable, but it's uglier because the functions need to know a lot
more about toasting; is it really worth it?

> 2. commands/command.c Some of the recursion to inherited tables passes
> the inhOpt from the parent rather than setting false.

That would be a bug, but I can't see any such error in current CVS.
Where are you looking?

> 3. alter table add constraint doesn't (on the face of it) prevent adding
> constraints to system tables if you're the superuser.

Should it?  They'd be ignored anyway by most internal operations.
I suppose at the very least it should check usecatupd...

> 4. New function-call interface is mainly documented in fmgr/README which
> is in the future tense. Should this go into a reference manual section
> instead? (those bits that it's good for programmer-users to know)

There is some documentation in xfunc.sgml, but I have no objection to
transposing more of the README into the SGML docs.  Just haven't got
round to it.

> 2) TOAST valueids. If MVCC works just as well on TOAST tables, then the
> update process is much simplified as an amended value doesn't need a new
> valueid.

Not sure that that's safe; need to think more.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-10-17 00:47:57
Subject: Re: pgcrypto in HISTORY
Previous:From: Tom LaneDate: 2001-10-16 21:14:17
Subject: Re: FW: [HACKERS] Problem on AIX with current

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group