Skip site navigation (1) Skip section navigation (2)

Re: Further patch for VS2005

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Further patch for VS2005
Date: 2006-06-26 20:47:11
Message-ID: 22740.1151354831@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> *** src/pl/plpython/plpython.c	25 Jun 2006 00:18:24 -0000	1.83
> --- src/pl/plpython/plpython.c	26 Jun 2006 13:58:56 -0000
> ***************
> *** 10,16 ****
> --- 10,19 ----
>   /* Python uses #pragma to bring in a non-default libpython on VC++ if
>    * _DEBUG is defined */
>   #undef _DEBUG
> + /* Also hide away errcode, since we load Python.h before postgres.h */
> + #define errcode __vc_errcode
>   #include <Python.h>
> + #undef errcode
>   #define _DEBUG
>   #else
>   #include <Python.h>

BTW, it strikes me as a fairly bad idea to be including <Python.h>
first; that goes directly against the conventions we established to be
sure that largefile support doesn't break.  Has anyone looked into
making plpython.c conform to project standards by including postgres.h
first?

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2006-06-26 20:54:07
Subject: Re: [PATCHES] Non-transactional pg_class, try 2
Previous:From: Simon RiggsDate: 2006-06-26 20:12:55
Subject: Re: [PATCHES] Non-transactional pg_class, try 2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group