Skip site navigation (1) Skip section navigation (2)

Re: DTrace probe patch for OS X Leopard

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: DTrace probe patch for OS X Leopard
Date: 2008-02-29 05:44:35
Message-ID: 22697.1204263875@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> writes:
> Peter Eisentraut wrote:
>> Is c.h the right place to include this?  The probes are only in the backend 
>> code, so perhaps postgres.h would be more appropriate.  Or just include it in 
>> the .c files that need it, of which there are only 3.
>> 
> I think putting probes.h in c.h is the right place. It's true that the 
> probes are only in the backend now and only in a few files, but in the 
> future I can foresee probes added to more files in the backend, the 
> procedural language code or any of the commands (initdb, psql, etc).

I agree with Peter.  There are a whole lot of include files that are
needed by way more than 3 .c files, and yet are not folded into
postgres.h.  c.h is right out.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2008-02-29 06:32:40
Subject: Re: tuplestore_putvalues()
Previous:From: Andrew DunstanDate: 2008-02-29 05:17:51
Subject: Re: Fix for initdb failures on Vista

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group