Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] BUG #3973: pg_dump using inherited tables do not always restore

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Alex Hunsaker" <badalex(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] BUG #3973: pg_dump using inherited tables do not always restore
Date: 2008-03-03 23:39:50
Message-ID: 2266.1204587590@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
"Alex Hunsaker" <badalex(at)gmail(dot)com> writes:
> On Wed, Feb 20, 2008 at 3:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Actually the bug is that ALTER TABLE allows you to do that.  It should
>> not be possible to drop an inherited constraint, but right now there's
>> not enough information in the system catalogs to detect the situation.
>> Fixing this has been on the TODO list for awhile:

> Hrm how about something like the attached patch?

It seems much more restrictive than necessary, plus it does nothing
for the check-constraint case.  My recollection of the previous
discussion about how to fix this was that we needed to add an inhcount
column to pg_constraint, and add entries for not-null constraints (at
least inherited ones) to pg_constraint so that they'd be able to have
inhcount fields.  The latter would also allow us to attach names to
not-null constraints, which I think is required by spec but we've never
supported.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2008-03-04 03:24:33
Subject: Re: BUG #3983: pgxs files missing from binary installation
Previous:From: Tom LaneDate: 2008-03-03 22:44:31
Subject: Re: BUG #4008: accepts invalid input with domaintypes and outer joins

pgsql-patches by date

Next:From: Brendan JurdDate: 2008-03-04 03:15:53
Subject: Re: [GENERAL] Empty arrays with ARRAY[]
Previous:From: Bruce MomjianDate: 2008-03-03 21:14:02
Subject: Re: [PATCHES] Incomplete docs for restore_command for hot standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group