Skip site navigation (1) Skip section navigation (2)

Re: BUG #3031: PHP (and others?) cannot close a connection when "in" a COPY-statement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Arjen van der Meijden <acmmailing(at)tweakers(dot)net>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #3031: PHP (and others?) cannot close a connection when "in" a COPY-statement
Date: 2007-02-20 07:07:52
Message-ID: 22641.1171955272@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Arjen van der Meijden <acmmailing(at)tweakers(dot)net> writes:
> I had a look at that _close_pgsql_link-function and this it the code:

>      while ((res = PQgetResult(link))) {
>          PQclear(res);
>      }

> So there is indeed a very clear loop. But I'm not sure whether this code 
> is incorrect as a generic "close the connection cleanly without memory 
> leaks"-function?

It's surely incorrect as a means of getting out of a COPY state.  To
tell the truth, if their intention is to close the connection
unceremoniously, they should just do that, ie PQfinish or just quit
the application.  So I'd suggest removing that loop.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Arjen van der MeijdenDate: 2007-02-20 07:21:25
Subject: Re: BUG #3031: PHP (and others?) cannot close a connection when "in" a COPY-statement
Previous:From: Arjen van der MeijdenDate: 2007-02-20 06:42:17
Subject: Re: BUG #3031: PHP (and others?) cannot close a connection when "in" a COPY-statement

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group