Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tsutomu Yamada wrote:
>> This patch using VirtualAlloc()/VirtualFree() to avoid failing in
>> reattach to shared memory.
> Since this fixes a very annoying bug present in older versions, I think
> this should be backpatched all the way back to 8.2.
Agreed, but first we need some evidence that it actually fixes the
problem. How can we acquire such evidence?
> - please use ereport() instead of elog() for error messages
This is only appropriate if they're user-facing messages, which probably
errors in this area are not ...
regards, tom lane