Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] "could not reattach to shared memory" on Windows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] "could not reattach to shared memory" on Windows
Date: 2009-07-14 15:23:42
Message-ID: 22601.1247585022@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tsutomu Yamada wrote:
>> This patch using VirtualAlloc()/VirtualFree() to avoid failing in
>> reattach to shared memory.

> Since this fixes a very annoying bug present in older versions, I think
> this should be backpatched all the way back to 8.2.

Agreed, but first we need some evidence that it actually fixes the
problem.  How can we acquire such evidence?

> - please use ereport() instead of elog() for error messages

This is only appropriate if they're user-facing messages, which probably
errors in this area are not ...

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Oleg BartunovDate: 2009-07-14 15:25:20
Subject: Prefix support for synonym dictionary
Previous:From: Alvaro HerreraDate: 2009-07-14 15:18:40
Subject: Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group