momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.
This patch is a perfect example of why unreviewed patches should not
go in during beta.
So far I have noticed the following problems with it:
* Added reference page wasn't linked into the docs build.
* Added a field to struct AlterTableStmt, but did not do the necessary
housekeeping for extending a Node (eg, copyfuncs and equalfuncs
adjustments), nor make sure the field is validly set in every place
an AlterTableStmt is constructed.
* ALTER INDEX RENAME doesn't actually work.
regression=# alter index foo_pkey rename to zzz;
ERROR: unrecognized rename stmt type: 9
That's not counting the problem someone else already reported with
regards, tom lane
In response to
pgsql-committers by date
|Next:||From: Bruce Momjian||Date: 2004-08-21 18:45:59|
|Subject: pgsql-server: Fix tab completion for ALTER INDEX.|
|Previous:||From: Tom Lane||Date: 2004-08-21 16:16:04|
|Subject: pgsql-server: Seems it would be nice if the ALTER INDEX ref page were |