From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces. |
Date: | 2004-08-21 17:21:15 |
Message-ID: | 22431.1093108875@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.
This patch is a perfect example of why unreviewed patches should not
go in during beta.
So far I have noticed the following problems with it:
* Added reference page wasn't linked into the docs build.
* Added a field to struct AlterTableStmt, but did not do the necessary
housekeeping for extending a Node (eg, copyfuncs and equalfuncs
adjustments), nor make sure the field is validly set in every place
an AlterTableStmt is constructed.
* ALTER INDEX RENAME doesn't actually work.
regression=# alter index foo_pkey rename to zzz;
ERROR: unrecognized rename stmt type: 9
That's not counting the problem someone else already reported with
incorrect tab-completion.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-08-21 18:45:59 | pgsql-server: Fix tab completion for ALTER INDEX. |
Previous Message | Tom Lane | 2004-08-21 16:16:04 | pgsql-server: Seems it would be nice if the ALTER INDEX ref page were |