| From: | George Barnett <gbarnett(at)atlassian(dot)com> |
|---|---|
| To: | Florian Pflug <fgp(at)phlo(dot)org> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to improve reliability of postgresql on linux nfs |
| Date: | 2011-09-12 06:46:53 |
| Message-ID: | 223BF4DE-B274-4428-8325-7C8E8250073B@atlassian.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/09/2011, at 3:59 PM, Florian Pflug wrote:
> If you really meant to say "intr" there (and not "nointr") then that probably explains the partial writes.
>
> Still, I agree with Noah and Kevin that we ought to deal more gracefully with this, i.e. resubmit after a partial read() or write(). AFAICS there's nothing to be gained by not doing that, and the increase in code complexity should be negligible. If we do that, however, I believe we might as well handle EINTR correctly, even if SA_RESTART should prevent us from ever seeing that.
Hi Florian,
You are indeed correct. Setting nointr also resolves my issue. I could swear I checked this, but obviously not.
It does still concern me that pgsql did not deal with this as gracefully as other software. I hope the list will consider a patch to resolve that.
Thanks in advance,
George
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2011-09-12 07:41:04 | Re: [v9.2] DROP statement reworks |
| Previous Message | Jun Ishiduka | 2011-09-12 06:46:37 | Re: Online base backup from the hot-standby |