Re: ExecTidReScan exprCtxt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: ExecTidReScan exprCtxt
Date: 2009-12-28 19:54:56
Message-ID: 22396.1262030096@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> In ExecTidReScan, we have the following:
> /* If we are being passed an outer tuple, save it for runtime
> key calc */
> if (exprCtxt != NULL)
> node->ss.ps.ps_ExprContext->ecxt_outertuple =
> exprCtxt->ecxt_outertuple;

> Is this dead code?

I don't think it's reachable at the moment, but we do have interest
in allowing joins using the TID value. See for example
http://archives.postgresql.org/pgsql-hackers/2009-01/msg01746.php
http://archives.postgresql.org/pgsql-performance/2007-04/msg00231.php
So I wouldn't be in favor of removing it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-28 20:18:08 Re: [PATCH] Provide rowcount for utility SELECTs
Previous Message Robert Haas 2009-12-28 19:19:08 ExecTidReScan exprCtxt