Skip site navigation (1) Skip section navigation (2)

Re: Command Triggers, patch v11

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Thom Brown <thom(at)linux(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Subject: Re: Command Triggers, patch v11
Date: 2012-02-28 00:21:38
Message-ID: 22328.1330388498@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andres Freund <andres(at)anarazel(dot)de> writes:
> I refreshed the patch so it works again on current HEAD. Basically some 
> trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The latter doesn't 
> seem necessary to me after the changes, so I simply ditched it. Am I missing 
> something?

No, that was only needed because execMain.c was overriding somebody
else's tuple receiver.  If you're putting the right receiver into the
QueryDesc to start with, it shouldn't be necessary.

I'm confused by this though:

> This basically includes a revert of d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b

I don't find that commit ID anywhere.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Noah MischDate: 2012-02-28 00:28:14
Subject: Re: foreign key locks, 2nd attempt
Previous:From: Tom LaneDate: 2012-02-27 23:54:41
Subject: Re: Command Triggers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group