Neil Conway <neilc(at)samurai(dot)com> writes:
> The implementation is pretty ugly -- it clutters ExecuteStmt and Query
> with fields that really do not belong there. Per previous discussion, I
> think it would be better to refactor the CREATE TABLE AS implementation
> to be essentially a CREATE TABLE followed by a INSERT ... SELECT.
I kinda wonder why bother at all. I don't see any good reason why
people shouldn't issue two statements.
>> if (stmt->intoTableSpaceName)
>> qry->intoTableSpaceName = pstrdup(stmt->intoTableSpaceName);
>> qry->intoTableSpaceName = NULL;
> You can omit the "else", as makeNode() zeroes all the fields of the new
For that matter, why not just
qry->intoTableSpaceName = stmt->intoTableSpaceName;
There's no need for the string-copy operation here, is there?
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Stephen Frost||Date: 2006-02-14 20:49:12|
|Subject: Re: BUG #2246: Bad malloc interactions: ecpg, openssl|
|Previous:||From: Neil Conway||Date: 2006-02-14 20:27:12|
|Subject: Re: add additional options to CREATE TABLE ... AS|