Skip site navigation (1) Skip section navigation (2)

Re: Allow the identifier length to be increased via a configure option

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Allow the identifier length to be increased via a configure option
Date: 2006-12-27 20:29:48
Message-ID: 22139.1167251388@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Dhanaraj M wrote:
>> I am sending the patch for the following TODO item:
>> Allow the identifier length to be increased via a configure option

> You should use pg_config.h, not mangle postgres_ext.h like that.  Or
> maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
> I wouldn't do that, really).

I'm wondering how this got into the TODO list.  It seems rather
pointless, and likely to create client compatibility problems (if not,
why is NAMEDATALEN exported at all?)

A bigger problem with the proposed patch is that it makes it look like
you can set the identifier length to any random number; the restrictions
mentioned in postgres_ext.h aren't enforced or even displayed to the
user of configure.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Roman KononovDate: 2006-12-27 20:43:04
Subject: Re: [BUGS] BUG #2846: inconsistent and confusing handling of underflows,
Previous:From: Roman KononovDate: 2006-12-27 20:27:10
Subject: Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling

pgsql-patches by date

Next:From: Roman KononovDate: 2006-12-27 20:43:04
Subject: Re: [BUGS] BUG #2846: inconsistent and confusing handling of underflows,
Previous:From: Roman KononovDate: 2006-12-27 20:27:10
Subject: Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing handling

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group