Skip site navigation (1) Skip section navigation (2)

Re: explain doesn't work with execute using

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: explain doesn't work with execute using
Date: 2008-06-01 16:18:40
Message-ID: 22117.1212337120@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
"Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> writes:
> 2008/6/1 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> What do you think a "less invasive" patch would be, anyway?  I don't
>> buy that, say, having SPI_cursor_open_with_args set the flag but
>> SPI_cursor_open not do so is any safer.  There is no difference between
>> the two as to what might get executed, so if there's a problem then
>> both would be at risk.

> SPI_cursor_open_with_args is new function, it's used only in FOR
> EXECUTE statement - and in this context variables are really
> constants.

This argument seems entirely bogus.  How are they any more constant
than in the other case?  The value isn't going to change for the life
of the portal in either case.

ISTM you're expecting EXPLAIN to behave in some magic way that has
got little to do with "correctness".

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2008-06-01 16:49:49
Subject: Re: explain doesn't work with execute using
Previous:From: Ron MayerDate: 2008-06-01 16:11:27
Subject: Re: Overhauling GUCS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group