Re: Update obsolete text in indexam.sgml

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "'PostgreSQL-development'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Update obsolete text in indexam.sgml
Date: 2012-11-05 18:46:48
Message-ID: 22069.1352141208@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> ISTM it would be better to update the text about index cost estimation in
> indexam.sgml. Please find attached a patch.

I'm not too thrilled with the proposed patch. In the first place, I
don't think it's necessary to address costing of index order-by
expressions in an introductory explanation. It seems likely that no FDW
will ever need to deal with that at all. In the second, this change
makes the code less clear, not more so, because it introduces a variable
indexQuals without showing where you would get that value from.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-11-05 18:47:58 Re: Deprecations in authentication
Previous Message Jan Urbański 2012-11-05 18:45:52 Re: [PATCH] PL/Python: Add spidata to all spiexceptions