Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Should libedit be preferred to libreadline?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-12-02 14:14:31
Message-ID: 2198.1133532871@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patchespgsql-ports
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I'm concerned that this still gives nondeterministic behavior.  There's 
> no way to say, "I want readline, period" or "I want libedit, period".  
> I'd prefer simple --with-readline and --with-libedit, giving one turns 
> off the other, giving both is an error.

OTOH that doesn't provide a way to express "I'll take either".  Given
that I'll-take-either has so far satisfied 99.44% of users, getting rid
of it doesn't seem like the best plan.

It might be possible to set things up so that you can specify "I'll take
either" by writing both switches, and further that the order in which
you write the switches determines the preference --- though I'm not
entirely sure how to do the latter within the autoconf framework.

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Andrew DunstanDate: 2005-12-02 15:02:14
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Peter EisentrautDate: 2005-12-02 08:28:19
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

pgsql-hackers by date

Next:From: Tom LaneDate: 2005-12-02 14:18:01
Subject: Re: Shared locking in slru.c
Previous:From: Pollard, MikeDate: 2005-12-02 12:57:50
Subject: Re: generalizing the planner knobs

pgsql-patches by date

Next:From: Andrew DunstanDate: 2005-12-02 15:02:14
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Andreas SeltenreichDate: 2005-12-02 13:59:30
Subject: Re: TODO item -- Improve psql's handling of multi-line queries

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group