| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | dg(at)illustra(dot)com (David Gould) |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [HACKERS] s_lock.h busted |
| Date: | 1998-07-20 19:41:43 |
| Message-ID: | 21939.900963703@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
dg(at)illustra(dot)com (David Gould) writes:
> Arrrrgggghhh!!!!
> These were meant to be in the conditional blocks at the end of the file so
> that if (and only if) no definition existed we would get a default. So:
> #ifndef S_UNLOCK
> #define S_UNLOCK(lock) (*(lock) = 0)
> #endif
> #ifndef S_INIT_LOCK
> #define S_INIT_LOCK(lock) S_UNLOCK(lock)
> #endif
Right, but those default definitions were *already there*.
The lines I was complaining about were added immediately after the
default definitions, and overrode *any* prior definition of the macros.
As far as I can see they were just a typo/thinko.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 1998-07-20 20:20:55 | Re: [HACKERS] Current sources?t |
| Previous Message | David Hartwig | 1998-07-20 19:35:23 | Re: [HACKERS] Current sources? |