Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] s_lock.h busted

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: dg(at)illustra(dot)com (David Gould)
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] s_lock.h busted
Date: 1998-07-20 19:41:43
Message-ID: 21939.900963703@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
dg(at)illustra(dot)com (David Gould) writes:
> Arrrrgggghhh!!!!
> These were meant to be in the conditional blocks at the end of the file so
> that if (and only if) no definition existed we would get a default. So:
> #ifndef S_UNLOCK
> #define S_UNLOCK(lock)  (*(lock) = 0)
> #endif
> #ifndef S_INIT_LOCK
> #define S_INIT_LOCK(lock)       S_UNLOCK(lock)
> #endif

Right, but those default definitions were *already there*.

The lines I was complaining about were added immediately after the
default definitions, and overrode *any* prior definition of the macros.
As far as I can see they were just a typo/thinko.

			regards, tom lane

pgsql-hackers by date

Next:From: Bruce MomjianDate: 1998-07-20 20:20:55
Subject: Re: [HACKERS] Current sources?t
Previous:From: David HartwigDate: 1998-07-20 19:35:23
Subject: Re: [HACKERS] Current sources?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group