Skip site navigation (1) Skip section navigation (2)

Re: Preliminary patch for tsearch example dictionaries/parsers in contrib

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: karpov(at)sao(dot)ru (Sergey V(dot) Karpov)
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Preliminary patch for tsearch example dictionaries/parsers in contrib
Date: 2007-10-10 18:50:10
Message-ID: 21747.1192042210@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
karpov(at)sao(dot)ru (Sergey V. Karpov) writes:
> I've prepared reduced and renamed version of the examples. It may be
> downloaded at 
> http://lynx.sao.ru/~karpov/tmp/ts_examples.tar.gz

>  - dict_xsyn now uses the same code to locate its config as built-in
>    dictionaries, and can't access files outside
>    $(prefix)/share/tsearch_data/.

Good, did you also fix it to do encoding conversion while reading the file?

> It still has a complicated source tree with subfolders for each
> example. Have I to break it into three separate contrib modules? Or
> combine into one with three build targets (this will break MSVC build)?

I think the consensus is for one module per top-level contrib directory.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Sergey V. KarpovDate: 2007-10-10 19:34:13
Subject: Re: Preliminary patch for tsearch example dictionaries/parsers in contrib
Previous:From: Henry B. HotzDate: 2007-10-10 18:35:00
Subject: Re: Preliminary GSSAPI Patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group