Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Date: 2007-06-26 15:13:02
Message-ID: 21672.1182870782@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I'm confused. Won't pg_dump quote the keywords it knows its postgres 
> version will need quoted? We can't expect it to have knowledge of future 
> requirements for quoting, unless someone really does invent time travel 
> (in which case someone could just go to the future and bring back 
> version 107.6 and save us all the trouble).

Yeah.  I'm disinclined to pre-emptively quote things for pie-in-the-sky
patches.  WITH is already a grammar keyword, so it's not a big deal to
tweak things to quote it, but adding a dozen keywords that have zero
functionality in the grammar is another thing entirely.

Also, the fact that this particular form of the grammar requires
reserving the keywords does not prove that there is no way to have the
features without that.  I'd want to see us try a little harder first.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Gregory StarkDate: 2007-06-26 15:15:07
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Previous:From: Josh BerkusDate: 2007-06-26 14:59:25
Subject: Re: [PATCHES] New Zealand - TZ change

pgsql-committers by date

Next:From: Gregory StarkDate: 2007-06-26 15:15:07
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Previous:From: Andrew DunstanDate: 2007-06-26 14:45:05
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group